This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix single quotes uses for JSON examples. #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edznux
changed the title
ramya-rao-a
approved these changes
Mar 3, 2019
There was a problem hiding this comment.
Looks like this is your first PR to this project @Edznux, Thanks & Welcome!
Apologies for taking so long to get to this PR, it somehow was lost in the sea of PRs we received in October for Hactoberfest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There were some single quotes in use for the JSON config file examples.
As JSON doesn't allow single quotes the UI was returning the error "[jsonc] Value expected" if they were copy-pasted. This was a little bit confusing.
Thanks